[PATCH] D73534: [WIP][DebugInfo] Enable the debug entry values feature by default

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1370-1371
   // Otherwise we successfully unfolded a load that we can hoist.
+  if (MI->isCall())
+    MF.eraseCallSiteInfo(MI);
   MI->eraseFromParent();
----------------
dstenb wrote:
> Would it be possible to move these `eraseCallSiteInfo() / moveCallSiteInfo()` fixes to parent patch(es)? I guess that would mean that `-debug-entry-values` would have to be added to a number of tests where you saw those issues, just to be removed by this patch again, but I think it may overall make it easier to review the changes.
That makes sense to me.

I did not want to do such thing because we will need to remove the experimental flag, but I see that is the only option to see the reason for the `*CallSiteInfo()` changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534