[PATCH] D73518: [ELF] Mention symbol name in reportRangeError()

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

I think this is step in the right direction. I tend to find that relocation out of range errors tend to be more useful to linker developers (via bug reports) as there is often little that a user can do about it, and it often represents either a fault in the linker or a misuse of a relocation in the compiler, I think we could tend to include information that would help us diagnose problems.



================
Comment at: lld/ELF/Relocations.cpp:105
+    hint = "; references " + lld::toString(*rel.sym) +
+           getDefinedLocation(*rel.sym);
+
----------------
grimar wrote:
> It can probably print "references local symbol" for local symbols?
> 
Another possibility would be to distinguish between symbol and PLT entry for symbol. I think that could be a future improvement though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73518/new/

https://reviews.llvm.org/D73518