[PATCH] D73550: Prevent building with MSVC 14.24

Tue Jan 28 07:08:37 PST 2020

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

In D73550#1844563 <https://reviews.llvm.org/D73550#1844563>, @thakis wrote:

> In D73550#1844539 <https://reviews.llvm.org/D73550#1844539>, @hans wrote:
>
> > Seems reasonable to me. Should we comment on the upstream bug that this breaks LLVM? I see there's a reduced repro, but I don't see LLVM mentioned.
>
>
> Sounds like it's already fixed upstream, so if the motivation is to help prioritize the bug then that's not necessary.

The idea was to highlight that this breaks a popular open-source project and that maybe they should include it in their testing. I'll add a note on the bug.

> 
> 
>> On second thought, while it's not strictly our problem, what is a user who runs into this supposed to do? AFAIK, Microsoft doesn't provide access to old compiler versions within the same family (2019), so unless you have an old install lying around or want to try the next preview, what to do?
> 
> You can get a newer MSVC, or you can use clang-cl as host compiler :)

The newer MSVC hasn't been released yet though.

> 
> 
>> Would it be better to selectively disable optimization of the miscompiled function?
> 
> I think this change here is better than not changing anything, and I don't want to spend more time on this than I already have.

Agreed this is better than nothing. lgtm.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73550/new/

https://reviews.llvm.org/D73550