[PATCH] D72027: [XCOFF][AIX] Support basic relocation type on AIX

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:611
 
+  assert(sizeof(XCOFFRelocation32) == XCOFF::RelocationSerializationSize32);
   auto RelocationOrErr =
----------------
I do not think we need to add assert here, implement of XCOFFRelocation32 is packed alignment.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp:22
 class PPCXCOFFObjectWriter : public MCXCOFFObjectTargetWriter {
+  static constexpr uint8_t SignBitMask = 0x80;
+
----------------
jasonliu wrote:
> hubert.reinterpretcast wrote:
> > There's `XR_SIGN_INDICATOR_MASK` in the codebase already.
> Unfortunately that's in llvm/Object. And we should have put it in llvm/BinaryFormat. 
we maybe need to have NFC patch to put the XR_SIGN_INDICATOR_MASK, XR_FIXUP_INDICATOR_MASK,  XR_BIASED_LENGTH_MASK into XCOFF.h , and shared with XCOFFObjectFile.h


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72027/new/

https://reviews.llvm.org/D72027