[PATCH] D73482: [AMDGPU] Fix lowering a16 image intrinsics
Ryan Taylor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 28 06:41:15 PST 2020
rtaylor added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5446-5448
+ SDValue Vec = DAG.getNode(ISD::UNDEF, DL, VectorVT);
+ Vec = DAG.getNode(ISD::INSERT_VECTOR_ELT, DL, VectorVT, Vec, AddrLo,
+ DAG.getConstant(0, DL, MVT::i32));
----------------
Couldn't this just be a SCALAR_TO_VECTOR to get the 0th element and create the vector? I think Nicolai mentioned this before?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73482/new/
https://reviews.llvm.org/D73482
More information about the llvm-commits
mailing list