[PATCH] D73443: [mlir][VectorOps] add reshape support during type_cast

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache requested changes to this revision.
nicolasvasilache added a comment.
This revision now requires changes to proceed.

Hello @ztuowen,

Thanks for your patch.
Note that conversions such as ` memref<?x8x?x8x16x9xf32> to memref<?x8x?x9xvector<8x16xf32>>` are not simple casts but indeed reshapes that change the internal layout and thus require moving data (i.e. copying).
As such this goes against the design principles of "cast" operations and makes the "moving data" requirement very implicit.

Could you please start a discussion in llvm.discourse.group explaining your use and what you would like to achieve?
There should be other ways to achieve what you want that do not modify the fundamental assumptions of ops.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73443/new/

https://reviews.llvm.org/D73443