[PATCH] D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions.

[Andrzej Warzynski via Phabricator via llvm-commits]

andwar added a comment.

One [nit] (non-blocking), otherwise LGTM.



================
Comment at: llvm/lib/Analysis/VFABIDemangling.cpp:472
+
+  assert(VF && "VF must be a positive value.");
   const VFShape Shape({VF, IsScalable, Parameters});
----------------
This should never be hit because for `VF = 0` `tryParseVLEN ` returns an error and `getECFromSignature` returns at least 1.

I'm just wondering, maybe less would be more here?





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73286/new/

https://reviews.llvm.org/D73286