[PATCH] D73523: [CMake][compiler-rt] Replace Windows backslashes with CMake ones
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 19:35:19 PST 2020
smeenai added inline comments.
================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:251-252
list(GET CONFIG_OUTPUT 1 LIBLIST)
- set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library")
- set(LLVM_XRAY_LIBLIST ${LIBLIST} CACHE STRING "Library list for LLVMXRay")
+ string(REPLACE "\\" "/" LDFLAGS ${LDFLAGS})
+ string(REPLACE "\\" "/" LIBLIST ${LIBLIST})
+ set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library" FORCE)
----------------
Does `file(TO_CMAKE_PATH)` work for this?
================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:253
+ string(REPLACE "\\" "/" LIBLIST ${LIBLIST})
+ set(LLVM_XRAY_LDFLAGS ${LDFLAGS} CACHE STRING "Linker flags for LLVMXRay library" FORCE)
+ set(LLVM_XRAY_LIBLIST ${LIBLIST} CACHE STRING "Library list for LLVMXRay" FORCE)
----------------
Why the addition of `FORCE`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73523/new/
https://reviews.llvm.org/D73523
More information about the llvm-commits
mailing list