[PATCH] D73304: [compiler-rt] enable test-suite discovery in source tree for libFuzzer & profile

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 16:24:15 PST 2020


rnk added inline comments.


================
Comment at: compiler-rt/test/fuzzer/CMakeLists.txt:67-68
+      ${LIBFUZZER_TEST_EXEC_DIR}/lit.site.cfg.py
+      MAIN_CONFIG
+      ${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
       )
----------------
This isn't going to work well when the same test suite is configured multiple times. If you look at llvm-lit.in, it just adds a dictionary entry. Adding multiple entries for the same source directory will make the later ones overwrite the first, and the choice will be arbitrary. If you could generalize it a bit to run the same test in all supported configs (static/dynamic/32/64) for example, that would be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73304/new/

https://reviews.llvm.org/D73304





More information about the llvm-commits mailing list