[PATCH] D73510: Reland "[StackColoring] Remap PseudoSourceValue frame indices via MachineFunction::getPSVManager()""

Mon Jan 27 15:47:33 PST 2020

rnk added a comment.

In D73510#1843302 <https://reviews.llvm.org/D73510#1843302>, @MaskRay wrote:

> `test/CodeGen/X86/catchpad-lifetime.ll` (added in rL257158 <https://reviews.llvm.org/rL257158> @majnemer) appears to be bit-rotted. If I delete:
>  ...
>  Not test will break.

I think it used to be covered by x64 tests, but then not long after in rG1ef654024f490b403494265c968570ca6bd800f3 <https://reviews.llvm.org/rG1ef654024f490b403494265c968570ca6bd800f3> we made most x64 catch objects fixed stack objects, which stack coloring should ignore. I ported one test to x86 in rGc7feb6b36aa8dac3cd20ffb9ad5980693ea9916e <https://reviews.llvm.org/rGc7feb6b36aa8dac3cd20ffb9ad5980693ea9916e>, but I'm not sure that one actually exercises this code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73510/new/

https://reviews.llvm.org/D73510