[PATCH] D73510: Reland "[StackColoring] Remap PseudoSourceValue frame indices via MachineFunction::getPSVManager()""

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 15:38:14 PST 2020


MaskRay added a comment.
Herald added a subscriber: wuzish.

`test/CodeGen/X86/catchpad-lifetime.ll` (added in rL257158 <https://reviews.llvm.org/rL257158> @majnemer) appears to be bit-rotted. If I delete:

  if (WinEHFuncInfo *EHInfo = MF->getWinEHFuncInfo())
    for (WinEHTryBlockMapEntry &TBME : EHInfo->TryBlockMap)
      for (WinEHHandlerType &H : TBME.HandlerArray)
        if (H.CatchObj.FrameIndex != std::numeric_limits<int>::max() &&
            SlotRemap.count(H.CatchObj.FrameIndex))
          H.CatchObj.FrameIndex = SlotRemap[H.CatchObj.FrameIndex];

Not test will break.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73510/new/

https://reviews.llvm.org/D73510





More information about the llvm-commits mailing list