[PATCH] D73507: [scudo][standalone] Secondary & general other improvements

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/lib/scudo/standalone/secondary.h:125
+      if (Size < BlockSize - getPageSizeCached() * 4U)
+        continue;
+      *H = reinterpret_cast<LargeBlock::Header *>(Entries[I].Block);
----------------
Would it make sense to move the IsFullEvents check here?
I.e. instead of clearing the cache after 4 failures to push a new entry, do it if the cache is X% full but we fail to find a suitable entry.

Probably would not make a difference in practice...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73507/new/

https://reviews.llvm.org/D73507