[PATCH] D73465: Add gpu::LaunchOp::addKernelArgument.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/GPU/IR/GPUDialect.cpp:283
+      return (block.back().emitError()
+              << "expected '" << gpu::ReturnOp::getOperationName() << "' or a "
+              << "terminator with successors")
----------------
nit: You can also use `append` to add arguments:

```
emitError().append(..., ..., ...).attachNote(...).append(..., ..., ...);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73465/new/

https://reviews.llvm.org/D73465