[PATCH] D73129: [LoopUnrollAndJam] Correctly update LoopInfo when unroll and jam more than 2-levels loop nests.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 13:48:19 PST 2020
dmgreen added a comment.
I'm happy with 3.
Nothing in this code needs the blocks to be processed in RPO? (or at least some defined order)? I'm a little surprised, but I don't spot anything.
================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp:146
+ BasicBlock *FirstBlock,
+ SmallPtrSetImpl<BasicBlock *> &Blocks,
+ ValueToValueMapTy &VMap,
----------------
BasicBlockSet &Blocks,
================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp:186
+ // Clone Blocks.
+ for (BasicBlock *BB : Blocks) {
+ if (BB == FirstBlock)
----------------
I think that it will matter that this isn't a deterministic order
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73129/new/
https://reviews.llvm.org/D73129
More information about the llvm-commits
mailing list