[PATCH] D72837: [AggressiveInstCombine] Add support for select instructions

Mon Jan 27 10:39:22 PST 2020

spatel added a comment.

In D72837#1841046 <https://reviews.llvm.org/D72837#1841046>, @nikic wrote:

> In D72837#1840886 <https://reviews.llvm.org/D72837#1840886>, @aymanmus wrote:
>
> > IMHO, there is no added value to splitting to 2 patches, the select changed are too obvious, and the compare is strongly related to the select changes.
>
>
> That's kind of the point: The select change is obvious and can land right away, the icmp part is trickier.

+1. Minimal patches are easier to review/debug, and we've already shown that this patch has tricky edge cases (and I don't know this code very well either). Also, please push the test file with baseline CHECKs as a preliminary commit.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72837/new/

https://reviews.llvm.org/D72837