[PATCH] D73325: [llvm][TextAPI/MachO] Support writing single macCatalyst platform

[Jonas Devlieghere via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG3ed88b052b19: [llvm][TextAPI/MachO] Support writing single macCatalyst platform (authored by JDevlieghere).

Changed prior to commit:
  https://reviews.llvm.org/D73325?vs=240091&id=240632#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73325/new/

https://reviews.llvm.org/D73325

Files:
  llvm/lib/TextAPI/MachO/TextStubCommon.cpp
  llvm/unittests/TextAPI/TextStubV3Tests.cpp


Index: llvm/unittests/TextAPI/TextStubV3Tests.cpp
===================================================================
--- llvm/unittests/TextAPI/TextStubV3Tests.cpp
+++ llvm/unittests/TextAPI/TextStubV3Tests.cpp
@@ -329,15 +329,11 @@
   EXPECT_EQ(FileType::TBD_V3, File->getFileType());
   EXPECT_EQ(Platform, *File->getPlatforms().begin());
 
-  // It's not currently possible to emit the iomac platform. Enable this once
-  // that's fixed.
-#if 0
   SmallString<4096> Buffer;
   raw_svector_ostream OS(Buffer);
   auto WriteResult = TextAPIWriter::writeToStream(OS, *File);
   EXPECT_TRUE(!WriteResult);
   EXPECT_EQ(stripWhitespace(tbd_v3_platform_iosmac), stripWhitespace(Buffer.c_str()));
-#endif
 }
 
 TEST(TBDv3, Platform_zippered) {
Index: llvm/lib/TextAPI/MachO/TextStubCommon.cpp
===================================================================
--- llvm/lib/TextAPI/MachO/TextStubCommon.cpp
+++ llvm/lib/TextAPI/MachO/TextStubCommon.cpp
@@ -74,6 +74,9 @@
   case PlatformKind::bridgeOS:
     OS << "bridgeos";
     break;
+  case PlatformKind::macCatalyst:
+    OS << "iosmac";
+    break;
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73325.240632.patch
Type: text/x-patch
Size: 1114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200127/92373116/attachment.bin>