[PATCH] D73461: [VE] call isel with stack passing

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 10:00:36 PST 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test nits



================
Comment at: llvm/test/CodeGen/VE/callstruct.ll:38
+; CHECK-NEXT:    or %s11, 0, %s9
+  %1 = alloca i64, align 8
+  %2 = bitcast i64* %1 to %struct.a*
----------------
Named values


================
Comment at: llvm/test/CodeGen/VE/callstruct.ll:57-62
+!2 = !{!3, !4, i64 0}
+!3 = !{!"a", !4, i64 0, !4, i64 4}
+!4 = !{!"int", !5, i64 0}
+!5 = !{!"omnipotent char", !6, i64 0}
+!6 = !{!"Simple C/C++ TBAA"}
+!7 = !{!3, !4, i64 4}
----------------
Shouldn't need any of this metadata?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73461/new/

https://reviews.llvm.org/D73461





More information about the llvm-commits mailing list