[PATCH] D73490: [LV] Remove nondeterminacy by changing LoopVectorizationLegality::Reductions from DenseMap to MapVector

Mon Jan 27 09:33:00 PST 2020

wmi marked 5 inline comments as done.
wmi added inline comments.

================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-order.ll:35
+  %t25 = add i32 %t22, undef
+  %t26 = add i32 %t25, undef
+  %t27 = add i32 %t26, undef
----------------
fhahn wrote:
> Is this chain needed? also the test is probably more robust if you use concrete values instead of undef. Same for the loop condition.
Ah, I thought bugpoint should already remove all the unnecessary instructions but seems not. I try and find the chain is not needed. Thanks for pointing that out.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73490/new/

https://reviews.llvm.org/D73490