[PATCH] D73474: [LLD][ELF][ARM] Do not insert interworking thunks for non STT_FUNC symbols

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 09:23:31 PST 2020


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

I've tested this patch, and with it applied, I can successfully boot an LLD-linked thumb2 kernel. Big thanks @peter.smith !!



================
Comment at: lld/test/ELF/arm-thumb-interwork-notfunc.s:10
+.arm
+arm_func_with_notype:
+ bx lr
----------------
how about adding a `.type func_with_notype, %notype` and again for `thumb_func_with_notype` (just to be explicit about the symbol type)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73474/new/

https://reviews.llvm.org/D73474





More information about the llvm-commits mailing list