[PATCH] D72796: AMDGPU/GlobalISel: Legalize unpacked d16 image operations
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 09:13:52 PST 2020
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2754
+
+ // FIXME: Do we need to notify the observer of the instruction change?
+ MI.getOperand(1).setReg(handleD16VData(B, *MRI, VData));
----------------
nhaehnle wrote:
> I think so?
legalizeIntrinsic doesn't have access to the observer, so I'll have to add that and audit the rest of these lowering at some point
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72796/new/
https://reviews.llvm.org/D72796
More information about the llvm-commits
mailing list