[PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 09:13:51 PST 2020
dblaikie added a comment.
Hmm - coming back to why these errors occur/need to be suppressed... why do these errors occur?
If it's only because of some missing refactorings/fixes to the APIs, I think maybe we should fix the APIs (since we can maintain the pretty printers in lock step with the APIs as they're committed to the same repository - we don't need backwards or forwards compatibility, etc)? Then we can skip the error handling & let it error out if we later break these APIs or add new pointer like type traits that are missing the relevant members, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72557/new/
https://reviews.llvm.org/D72557
More information about the llvm-commits
mailing list