[PATCH] D72430: AMDGPU/GlobalISel: Select llvm.amdcn.raw.buffer.load

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.

I have a nitpick, but either way LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2325
+  if (Overflow != 0) {
+    if (!BaseReg)
+      BaseReg = B.buildConstant(S32, Overflow).getReg(0);
----------------
Stylistically, I think it's preferable to put braces around both sides of the if/else if one side needs it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72430/new/

https://reviews.llvm.org/D72430