[PATCH] D72128: [llvm-objcopy][ELF] Allow setting SHF_EXCLUDE flag for ELF sections

Sergey Dmitriev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 06:58:34 PST 2020


sdmitriev added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/rename-section-flag-preserved.test:72-73
 # CHECK-NEXT:   ]
-
-# BAD-FLAG: unrecognized section flag 'xyzzy'
----------------
jhenderson wrote:
> I can see this is unreferenced in this test, but removing it shouldn't be part of this commit. Please make a separate change just deleting this line and the blank line above it, without need for further review.
I've just found that I accidentally missed this comment and because of that committed this change together with the other changes, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72128/new/

https://reviews.llvm.org/D72128





More information about the llvm-commits mailing list