[PATCH] D73246: [WebAssembly] Add WebAssembly support to llvm-symbolizer

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/wasm-basic.s:4
+
+       
+foo:
----------------
Nit: no need for two blank lines.


================
Comment at: llvm/test/tools/llvm-symbolizer/wasm-basic.s:16-18
+# Byte 1 is the function length and 2 is the locals declaration.
+# Currently no line corresponds to them. TODO: create a loc for .functype?
+# Test 2 functions to ensure wasm's function-sections system works
----------------
Nit: Use two '##' characters for comments for readability. Also, consider putting the TODO on its own line to make it stand out better. Finally, missing trailing full stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73246/new/

https://reviews.llvm.org/D73246