[llvm] 70cbf8c - [X86] Make `llc --help` output readable again

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 06:25:43 PST 2020


Thanks!

On Mon, Jan 27, 2020 at 5:21 PM Hans Wennborg <hans at chromium.org> wrote:
>
> Thanks! Cherry-picked to 10.x in 256a0eaf23b213706f9ccb6b35152dc7a1c03290
>
> On Fri, Jan 24, 2020 at 2:46 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:
> >
> > I suspect this should be cherry-picked into 10.x branch
> >
> > On Sat, Jan 25, 2020 at 1:44 AM Roman Lebedev via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> > >
> > >
> > > Author: Roman Lebedev
> > > Date: 2020-01-25T01:43:52+03:00
> > > New Revision: 70cbf8c71c510077baadcad305fea6f62e830b06
> > >
> > > URL: https://github.com/llvm/llvm-project/commit/70cbf8c71c510077baadcad305fea6f62e830b06
> > > DIFF: https://github.com/llvm/llvm-project/commit/70cbf8c71c510077baadcad305fea6f62e830b06.diff
> > >
> > > LOG: [X86] Make `llc --help` output readable again
> > >
> > > Long `cl::value_desc()` is added right after the flag name,
> > > before `cl::desc()` column. And thus the `cl::desc()` column,
> > > for all flags, is padded to the right,
> > > which makes the output unreadable.
> > >
> > > Added:
> > >
> > >
> > > Modified:
> > >     llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
> > >
> > > Removed:
> > >
> > >
> > >
> > > ################################################################################
> > > diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
> > > index 654833260f8f..59502c56396a 100644
> > > --- a/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
> > > +++ b/llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
> > > @@ -85,13 +85,13 @@ cl::opt<unsigned> X86AlignBranchBoundary(
> > >
> > >  cl::opt<X86AlignBranchKind, true, cl::parser<std::string>> X86AlignBranch(
> > >      "x86-align-branch",
> > > -    cl::desc("Specify types of branches to align (plus separated list of "
> > > -             "types). The branches's types are combination of jcc, fused, "
> > > -             "jmp, call, ret, indirect."),
> > > -    cl::value_desc("jcc indicates conditional jumps, fused indicates fused "
> > > -                   "conditional jumps, jmp indicates unconditional jumps, call "
> > > -                   "indicates direct and indirect calls, ret indicates rets, "
> > > -                   "indirect indicates indirect jumps."),
> > > +    cl::desc(
> > > +        "Specify types of branches to align. The branches's types are "
> > > +        "combination of jcc, fused, jmp, call, ret, indirect. jcc indicates "
> > > +        "conditional jumps, fused indicates fused conditional jumps, jmp "
> > > +        "indicates unconditional jumps, call indicates direct and indirect "
> > > +        "calls, ret indicates rets, indirect indicates indirect jumps."),
> > > +    cl::value_desc("(plus separated list of types)"),
> > >      cl::location(X86AlignBranchKindLoc));
> > >
> > >  cl::opt<bool> X86AlignBranchWithin32BBoundaries(
> > >
> > >
> > >
> > > _______________________________________________
> > > llvm-commits mailing list
> > > llvm-commits at lists.llvm.org
> > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list