[PATCH] D73465: Add gpu::LaunchOp::addKernelArgument.
    Alex Zinenko via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jan 27 06:03:27 PST 2020
    
    
  
ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.
================
Comment at: mlir/include/mlir/Dialect/GPU/GPUOps.td:487
+    incovation of the `gpu.func`.
+    As `gpu.launch` does not return any values, it is expected that a
+    corresponding `gpu.return` also has no operands.
----------------
This says "gpu.launch" but the line above says "gpu.func". Let's use one everywhere and say the other is equivalent.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73465/new/
https://reviews.llvm.org/D73465
    
    
More information about the llvm-commits
mailing list