[PATCH] D73423: [LV] Do not try to sink dead instructions.

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 05:08:29 PST 2020


gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7135
+  // Dead instructions do not need sinking. Remove them from SinkAfter.
+  for (auto &Entry : make_early_inc_range(SinkAfter)) {
+    if (DeadInstructions.find(Entry.first) != DeadInstructions.end())
----------------
How about:
```
for (auto *Dead : DeadInstructions)
  SinkAfter.erase(Dead);

```
Would also facilitate filtering dead instructions from other maps if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73423/new/

https://reviews.llvm.org/D73423





More information about the llvm-commits mailing list