[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

Mon Jan 27 00:56:37 PST 2020

jhenderson added a comment.

Column information seems like enough to me for now. If we find a use-case for discriminator information as well as column info, then I'm open to adding it in the future though.

================
Comment at: llvm/test/tools/llvm-symbolizer/discriminator.test:3
+
+RUN: llvm-symbolizer --output-style=GNU -f --obj=%p/Inputs/discrim 0x400590 0x400575 | FileCheck %s
+
----------------
Let's add a test-case to show that LLVM style doesn't print the discriminator. Something like:

```
RUN: llvm-symbolizer --output-style=GNU -f --obj=%p/Inputs/discrim 0x400590 0x400575 | \
RUN:   FileCheck %s --check-prefix=LLVM --implicit-check-not="(discriminator"
CHECK: /tmp/discrim.c:5:12{{$}}
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318