[PATCH] D72601: GlobalISel: Lower G_WRITE_REGISTER
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 26 22:03:33 PST 2020
aemerson added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/write_register.ll:2
+; Runs original SDAG test with -global-isel
+; RUN: llc -global-isel -march=amdgcn -mcpu=bonaire -enable-misched=0 -verify-machineinstrs < %S/../write_register.ll | FileCheck -enable-var-scope %S/../write_register.ll
----------------
I don't know how I feel about this. Perhaps just add an extra run line to the existing test?
Since you're removing something from arm64 fallback, could you add a small test for arm64 as well?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72601/new/
https://reviews.llvm.org/D72601
More information about the llvm-commits
mailing list