[PATCH] D73111: GlobalISel: Reimplement widenScalar for G_UNMERGE_VALUES results
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 26 21:56:16 PST 2020
aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.
LGTM with additional comment.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1476
+
+ const int NumUnmerge = Unmerge->getNumOperands() - 1;
+ const int PartsPerUnmerge = WideTy.getSizeInBits() / DstTy.getSizeInBits();
----------------
A comment would be useful here explaining what this is trying to achieve.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73111/new/
https://reviews.llvm.org/D73111
More information about the llvm-commits
mailing list