[PATCH] D72400: [MLIR] Add OpenMP dialect with barrier operation

[River Riddle via Phabricator via llvm-commits]

rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.

I don't remember that we ever fully resolved this(adding OpenMP Dialect). Can you make a ping on llvm.discourse.group to make sure?



================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h:3
+//
+// Part of the MLIR Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
----------------
MLIR -> LLVM now


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h:9
+//
+// This file declares the OpenMP dialect in MLIR
+//
----------------
nit: Missing punctuation at the end of the line.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:3
+//
+// Part of the MLIR Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72400/new/

https://reviews.llvm.org/D72400