[PATCH] D72837: [AggressiveInstCombine] Add support for select instructions

Ayman Musa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 26 05:52:53 PST 2020


aymanmus updated this revision to Diff 240431.
aymanmus added a comment.

Following @nikic's comment:
I agree, the patch is missing some select exclusive tests.
Adding such test cases.
IMHO, there is no added value to splitting to 2 patches, the select changed are too obvious, and the compare is strongly related to the select changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72837/new/

https://reviews.llvm.org/D72837

Files:
  llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp
  llvm/test/Transforms/AggressiveInstCombine/trunc_select_cmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72837.240431.patch
Type: text/x-patch
Size: 16585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200126/8ad14a80/attachment.bin>


More information about the llvm-commits mailing list