[PATCH] D73396: AMDGPU/GlobalISel: Select G_SEXT_INREG

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sext-inreg.mir:36
+    %0:sgpr(s32) = COPY $sgpr0
+    %1:sgpr(s32) = G_SEXT_INREG %0, 1
+    $sgpr0 = COPY %1
----------------
Did you mean immediate value 2 here, instead of value 1?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sext-inreg.mir:131
+    %1:sgpr(s64) = G_SEXT_INREG %0, 1
+    $sgpr0_sgpr1 = COPY %1
+...
----------------
Ditto


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-sext-inreg.mir:267
+    %0:vgpr(s32) = COPY $vgpr0
+    %1:vgpr(s32) = G_SEXT_INREG %0, 1
+    $vgpr0 = COPY %1
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73396/new/

https://reviews.llvm.org/D73396