[PATCH] D73234: [gn] Paper over Py3 urllib2 incompatibility in gn/get.py
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 25 20:37:55 PST 2020
thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/utils/gn/get.py:12
+ # Python 3 moved urlopen to urllib.request.
+ import urllib.request as urllib2
import sys
----------------
Maybe try the py3 way first and then import the py2 as replacement, and move the script to use the py3 name.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73234/new/
https://reviews.llvm.org/D73234
More information about the llvm-commits
mailing list