[PATCH] D73419: [mlir][spirv] NFC: simplify load/store builder call sites

Ben Vanik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 25 16:08:47 PST 2020


benvanik accepted this revision.
benvanik added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td:268
+      Builder *builder, OperationState &state,
+      Value basePtr, /*optional*/IntegerAttr memory_access = {},
+      /*optional*/IntegerAttr alignment = {}
----------------
the /*optional*/ isn't required as you have the {} now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73419/new/

https://reviews.llvm.org/D73419





More information about the llvm-commits mailing list