[PATCH] D73404: [WIP] Basis of droping uses in llvm.assume.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 25 12:57:48 PST 2020


jdoerfert added a comment.

We need to split this patch. The droppable logic can be applied to regular assumes already so we can separate this from the operand bundle stuff at first. That should make the patches significantly smaller. You also need to separate D73404 <https://reviews.llvm.org/D73404> out.



================
Comment at: llvm/lib/IR/Value.cpp:181
+    assert(V != U->get() && "the value should have been changed");
+    U->removeFromList();
+  }
----------------
We have to make sure we handle "incomplete" operand bundles properly. I guess if we always go through KnowledgeRetention we can make sure of that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73404/new/

https://reviews.llvm.org/D73404





More information about the llvm-commits mailing list