[PATCH] D73415: [mlir][spirv] Relax verification to allow flexible placement

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added reviewers: denis13, benvanik.
Herald added subscribers: llvm-commits, liufengdb, lucyrfox, mgester, arpith-jacob, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

Thus far certain SPIR-V ops have been required to be in spv.module.
While this provides strong verification to catch unexpected errors,
it's quite rigid and makes progressive lowering difficult. Sometimes
we would like to partially lower ops from other dialects, which may
involve creating ops like global variables that should be placed in
other module-like ops. So this commit relaxes the requirement of
such SPIR-V ops' scope to module-like ops. Similarly for function-
like ops.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73415

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
  mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
  mlir/test/Dialect/SPIRV/control-flow-ops.mlir
  mlir/test/Dialect/SPIRV/structure-ops.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73415.240376.patch
Type: text/x-patch
Size: 4919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200125/39e51eb2/attachment.bin>