[PATCH] D72885: [WIP] Add Query API for llvm.assume holding attributes

Fri Jan 24 23:54:06 PST 2020

Tyker added a comment.

In D72885#1834094 <https://reviews.llvm.org/D72885#1834094>, @jdoerfert wrote:

> In D72885#1832612 <https://reviews.llvm.org/D72885#1832612>, @Tyker wrote:
>
> > In D72885#1827778 <https://reviews.llvm.org/D72885#1827778>, @jdoerfert wrote:
> >
> > > I won't review this properly till next week. Generally looks good so you can work on the next patch if you want to.
> >
> >
> > i started working on ignoring or dropping uses in llvm.assume when a transformation is use sensitive.
>
>
> Great! Can you share it on phab so I can reference it in my email (see below).

i added it to phab (D73404 <https://reviews.llvm.org/D73404>) after cleaning it up.  sorry i toke soo long i haven't had the time i wanted to work on this.

>> In D72475#1821013 <https://reviews.llvm.org/D72475#1821013>, @jdoerfert wrote:
>> 
>>> Also because of that, and we do not have settled on this scheme in the RFC thread.
>> 
>> 
>> i would like to have confirmation that the operand bundles representation is what we are going for ?
>>  i don't recall it being a point of contention but it wasn't explicitly approved. and you mentioned in that the issue as not settled.
> 
> Correct. I'll send another email today, describing our progress and hoping ppl agree this is a good solution :)

thanks for the mail.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72885/new/

https://reviews.llvm.org/D72885