[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

In D73318#1839196 <https://reviews.llvm.org/D73318#1839196>, @saugustine wrote:

> In D73318#1838181 <https://reviews.llvm.org/D73318#1838181>, @jhenderson wrote:
>
> > Is there a particular reason to restrict this to GNU style? I think it's okay to expand on the LLVM style too, but might be worth getting more opinions on it.
>
>
> LLVM output style already prints the column number (file:line:column), which tells you the same thing as the discriminator, but at a higher level that is more friendly for users. I'm open to adding it, but it seems a bit redundant.
>
> Otherwise updated.


So it would print:

  foo
  /tmp/discrim.c:5:17 (discriminator 2)

It doesn't seem *that* redundant so I'd also consider adding it for llvm style too. But I don't particularly need it.
FWIW, --verbose mode also includes discriminator for both LLVM and GNU style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318