[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

In D72798#1838110 <https://reviews.llvm.org/D72798#1838110>, @simoll wrote:

> Nit: You might want to add that list order does not imply preference (it's logically a set) and that the compiler is free to pick any listed vector function of its choosing.


Done

> Question: how does this interact with vector function metadata attached to a function declaration (if at all), eg does the call site list override that of the function?

Hum - I haven't really thought about that.  I think that more than "override", the local list should extend the one attached to the function. At the end, what we need to prevent is that the call sites don't mix up their respective list (as they may come from different compilation unit being merged).

My preference would be to forbid the attribute at all for functions, and leave it only for callinst, as vectorization is instantiated only when a call is seen. Any concerns on this approach?

> Otw, LGTM.

Thanks for your review, Simon!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798