[PATCH] D73317: [GISelKnownBits] Add support for PHIs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM

In D73317#1838994 <https://reviews.llvm.org/D73317#1838994>, @qcolombet wrote:

> > I do think copies should be ignored for depth. Other places generally try to treat intervening copies as irrelevant
>
> Fair enough. I still think we shouldn’t insert useless copies long term (those are not free).


I agree. I looked at doing this, and it wasn't clear to me what guarantees the MachineIRBuilder should provide for the insert point. You could potentially want to write code that relied on an instruction definitely being inserted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73317/new/

https://reviews.llvm.org/D73317