[PATCH] D73310: Allow Module name to be used to generate a unique Module ID

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 11:03:25 PST 2020


tmsriram added a comment.

In D73310#1839155 <https://reviews.llvm.org/D73310#1839155>, @pcc wrote:

> I am suggesting that you wouldn't change this function at all but would hash `getSourceFileName` yourself. (You shouldn't use `getModuleIdentifier` for anything that affects the contents of the output file because it isn't serialized.)


I modified https://reviews.llvm.org/D73307 to do exactly this.  I will delete this patch if the new change is alright.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73310/new/

https://reviews.llvm.org/D73310





More information about the llvm-commits mailing list