[PATCH] D73362: [mlir] EnumsGen: dissociate string form of integer enum from C++ symbol name

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added a comment.

Thanks Alex for adding this! Have you considered adding an additional parameter (defaulting to C++ enumerant symbol) for the string representation instead of duplicating all the cases? I can see this is also useful for BitEnumAttrCase and StrEnumAttrCase so it ends up we need to duplicate all the cases. Besides, the name of `IntStrEnumCase` can be quite confusing, given we have `IntEnumCase` and `StrEnumCase` (and in the future may have `StrStrEnumCase`/`BitStrEnumCase`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73362/new/

https://reviews.llvm.org/D73362