[PATCH] D70759: [llvm-symbolizer] Support debug file lookup using build ID
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 24 09:46:37 PST 2020
vsk added inline comments.
================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:303
+ return N.getDesc();
+ }
+ return {};
----------------
Does `Err` need to be checked here, after the loop?
>From `notes_begin`:
/// \param Err [out] an error to support fallible iteration, which should
/// be checked after iteration ends.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70759/new/
https://reviews.llvm.org/D70759
More information about the llvm-commits
mailing list