[PATCH] D73310: Allow Module name to be used to generate a unique Module ID

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 09:35:36 PST 2020


tmsriram added a comment.

In D73310#1838950 <https://reviews.llvm.org/D73310#1838950>, @pcc wrote:

> If you don't need a guarantee of uniqueness wouldn't it be better to just take a hash of `Module::getSourceFileName()` instead of looking at the names of the globals?


So you are suggesting that when "UseModuleId" is true, we just return the hash of getModuleIdentifier()?  That works for us and I can modify this function accordingly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73310/new/

https://reviews.llvm.org/D73310





More information about the llvm-commits mailing list