[PATCH] D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2)

Arthur O'Dwyer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 08:04:55 PST 2020


Quuxplusone added a comment.

I'm not qualified to comment on the functionality. This seems like it'll be OK with respect to `thread_local` on Mac OSX. No further comments from me.



================
Comment at: llvm/lib/Support/TimeProfiler.cpp:133
     // Emit all events for the main flame graph.
-    for (const auto &E : Entries) {
+    auto writeEvent = [&](auto &E, uint64_t Tid) {
       auto StartUs = E.getFlameGraphStartUs(StartTime);
----------------
`const auto &E`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71059/new/

https://reviews.llvm.org/D71059





More information about the llvm-commits mailing list