[PATCH] D72998: [IR] Attribute/AttrBuilder: use Value::MaximumAlignment magic constant
David Zarzycki via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 24 07:26:22 PST 2020
davezarzycki added a comment.
I understand not wanting to have trivial dependencies on IR for values like this, but what about creating `llvm/Support/InternalLimits.h` to hold values like this, and then *either* have `llvm::Value::MaximumAlignment` derive from the constant in the new file, or `static_assert` that the internal limit constant equals `llvm::Value::MaximumAlignment`?
At the very least, something in clang's IR generation logic should static_assert that the Sema constant is less than or equal to the LLVM constant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72998/new/
https://reviews.llvm.org/D72998
More information about the llvm-commits
mailing list