[PATCH] D73352: AMDGPU/GlobalISel: Legalize f64 G_FFLOOR for SI

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 07:17:37 PST 2020


arsenm created this revision.
arsenm added reviewers: mareko, nhaehnle, kerbowa.
Herald added subscribers: Petar.Avramovic, hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

Use cmp ord instead of cmp_class compared to the DAG version for the
nan check, but mostly try to match the existsing pattern.

      

I think the sign doesn't matter for fract, so we could do a little
better with the source modifier matching.

      

I think this is also still broken as in D22898 <https://reviews.llvm.org/D22898>, but I'm leaving it
as-is for now while I don't have an SI system to test on.


https://reviews.llvm.org/D73352

Files:
  llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
  llvm/lib/Target/AMDGPU/SIInstructions.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/floor.f64.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-ffloor.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73352.240184.patch
Type: text/x-patch
Size: 24687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200124/e1de28ab/attachment.bin>


More information about the llvm-commits mailing list