[PATCH] D73176: [ARM] Fix dropped dollar sign from symbols in branch targets
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 24 06:32:01 PST 2020
chill added a comment.
There's obviously lexer ambiguity in interpreting, e.g. the character sequence `$4` as a single `<identifier>` token, or as the two tokens `$` and a `<constant>`.
Looks like the tokenisation needs to be context dependent: in certain directives (`.global $4`) and instructions (`b $4`) the sequence needs to be interpreted a single identifier, and
in other contexts (`ldr r0, [r0, $4]`) as two separate tokens.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73176/new/
https://reviews.llvm.org/D73176
More information about the llvm-commits
mailing list