[PATCH] D73105: [llvm-readobj] - Add a test for --hash-table option.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 04:35:01 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-table.test:93-94
+## overriding the ELF header properties.
+  SHOff:   0x0
+  SHNum:   0
+Sections:
----------------
Perhaps change 0x0 -> 0 (or vice versa) for consistency/readability. Not a big issue though, if you prefer as is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73105/new/

https://reviews.llvm.org/D73105





More information about the llvm-commits mailing list